Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6750#discussion_r33991686
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkException.scala ---
    @@ -30,3 +30,13 @@ class SparkException(message: String, cause: Throwable)
      */
     private[spark] class SparkDriverExecutionException(cause: Throwable)
       extends SparkException("Execution error", cause)
    +
    +/**
    + * Exception indicating an error internal to Spark -- it is in an 
inconsistent state, not due
    + * to any error by the user
    + */
    +class SparkIllegalStateException(message: String, cause: Throwable)
    --- End diff --
    
    I'd prefer to stick with the existing strategy, which is to use 
IllegalStateExceptions and introduce this new exception in a separate PR (my 
understanding is that we do currently use IllegalStateExceptions only for 
things that aren't the user's fault; if not, agree with your sentiment that it 
would be nice to clean that up, but not as part of this PR).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to