Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6750#issuecomment-119279396
@kayousterhout I think I addressed your comments. I had some questions
about the best way to make the attemptId condition cleaner -- I went ahead with
one approach here
https://github.com/squito/spark/commit/19685bba6d4615b9b725032a070249255caa0ff8
but I'm open to other suggestions.
Also on making the check for multiple active task sets faster -- there are
a bunch of places that `activeTaskSets` is used with the existing structure.
It just makes the code more complicated to change all those usages. So instead
I added another variable for this purpose. But I'm happy to change that to
just be `activeTaskSets` if you prefer.
https://github.com/squito/spark/commit/b2faef52a5a2b49e8196a2f79f1f0c5349afd63e
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
