Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7247#discussion_r34075382
--- Diff: pom.xml ---
@@ -1110,6 +1110,10 @@
<artifactId>netty</artifactId>
</exclusion>
<exclusion>
+ <groupId>org.apache.flume</groupId>
--- End diff --
Does this exclusion belong in the child POM too? I had actually thought
potentially all of them should go, unless we systematically want to exclude
some deps from all uses of Flume across the project, of which there's really
only one now anyway. That is, if the reason for the exclusion is specific to
one child module, they can live there only. It's up to your better judgment
IMHO so LGTM either way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
