Github user cmccabe commented on a diff in the pull request:
https://github.com/apache/spark/pull/898#discussion_r13161839
--- Diff: core/src/main/scala/org/apache/spark/util/FileLogger.scala ---
@@ -149,13 +155,13 @@ private[spark] class FileLogger(
/**
* Flush the writer to disk manually.
*
- * If the Hadoop FileSystem is used, the underlying FSDataOutputStream
(r1.0.4) must be
- * sync()'ed manually as it does not support flush(), which is invoked
by when higher
- * level streams are flushed.
+ * When using a Hadoop filesystem, we need to invoke the hflush or sync
+ * method. In HDFS, hflush guarantees that the data gets to all the
--- End diff --
Either way is fine with me. The Apache license header uses two spaces and
a lot of the tools I use auto-correct to that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
