GitHub user kayousterhout opened a pull request:

    https://github.com/apache/spark/pull/7268

    [SPARK-8875] Remove BlockStoreShuffleFetcher class

    The shuffle code has gotten increasingly difficult to read as it has 
evolved, and many classes
    have evolved significantly since they were originally created. The 
BlockStoreShuffleFetcher class
    now serves little purpose other than to make the code more difficult to 
read; this commit moves its
    functionality into the ShuffleBlockFetcherIterator class.
    
    cc @massie @JoshRosen (Josh, this PR also removes the Try you pointed out 
as being confusing / not necessarily useful in a previous comment).  Matt, 
would be helpful to know whether this will interfere in any negative ways with 
your new shuffle PR (I took a look and it seems like this should still cleanly 
integrate with your parquet work, but want to double check).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kayousterhout/spark-1 SPARK-8875

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/7268.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #7268
    
----
commit 0bc0e595734dceba6973f6ebdbb056b530f6beb6
Author: Kay Ousterhout <[email protected]>
Date:   2015-07-07T20:50:30Z

    [SPARK-8875] Remove BlockStoreShuffleFetcher class
    
    The shuffle code has gotten increasingly difficult to read as it has 
evolved, and many classes
    have evolved significantly since they were originally created. The 
BlockStoreShuffleFetcher class
    now serves little purpose other than to make the code more difficult to 
read; this commit moves its
    functionality into the ShuffleBlockFetcherIterator class.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to