Github user mridulm commented on the pull request:
https://github.com/apache/spark/pull/7243#issuecomment-119375419
@vanzin I do not disagree with you - it would indeed be cleaner, and I do
agree with your point of view.
I had not looked at client mode when I fixed this, and my assumption that
it would work for both was not correct - but as you pointed out.
So currently this change works only for yarn cluster mode - while still of
value, it would require some rework when client mode needs to be fixed.
Unfortunately I am on 1.3 on cluster mode - and I cannot move to master or
test against that.
Which is why I am perfectly fine with closing this PR in case anyone wants
to fix it in a more principled manner. I just dont want the issue to not get
resolved before next release (we missed it for current already).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]