Github user nishkamravi2 commented on the pull request:
https://github.com/apache/spark/pull/7274#issuecomment-119381194
Overview of changes:
1. scheduleExecutorsOnWorkers rewritten and separated out (so it can be
unit tested)
2. allocateWorkerResourceToExecutors modified accordingly and simplified
Comments:
1. The two while loops in scheduleExecutorsOnWorkers can potentially be
fused into one
2. Would be good to add a couple of unit tests (we don't have any for
executor scheduling at the moment)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
