Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7256#discussion_r34106735
  
    --- Diff: python/pyspark/sql/types.py ---
    @@ -1160,18 +1150,22 @@ def _has_struct_or_date(dt):
     def _create_properties(fields):
         """Create properties according to fields"""
    --- End diff --
    
    basically my worry is that there is a lot of magic happening with the 
python implementation, and it is very hard to figure out what's going on 
without extensive comments.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to