Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7260#discussion_r34106792
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
    @@ -371,7 +371,7 @@ class HiveContext(sc: SparkContext) extends 
SQLContext(sc) {
       // Note that HiveUDFs will be overridden by functions registered in this 
context.
       @transient
       override protected[sql] lazy val functionRegistry: FunctionRegistry =
    -    new OverrideFunctionRegistry(new 
HiveFunctionRegistry(FunctionRegistry.builtin))
    +    new HiveFunctionRegistry(FunctionRegistry.builtin)
    --- End diff --
    
    Yes, that's the tricky thing, as this code path is hidden(never be called) 
as we had the wrapper of `OverrideFunctionRegistry`, see code in HiveContext:
    ```scala
    override protected[sql] lazy val functionRegistry: FunctionRegistry =
        new OverrideFunctionRegistry(new 
HiveFunctionRegistry(FunctionRegistry.builtin))
    ```
    
    Since the `OverrideFunctionRegistry` is removed, we should update this part 
too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to