Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7290#discussion_r34156601
  
    --- Diff: python/pyspark/mllib/linalg.py ---
    @@ -440,7 +440,7 @@ def __init__(self, size, *args):
             values (sorted by index).
     
             :param size: Size of the vector.
    -        :param args: Non-zero entries, as a dictionary, list of tupes,
    +        :param args: Non-zero entries, as a dictionary, list of tuples,
    --- End diff --
    
    This is not very accurate because we can take explicit zeros. Could you 
change it to
    
    `Active entries, as a dictionary {index: value, ...}, a list of tuples 
[(index, value), ...], or a list of strictly increasing indices and a list of 
values [index, ...], [value, ...]. Inactive entries are treated as zeros.`
    
    It wold be nice if you can also update the Scala doc (in a separate PR).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to