Github user squito commented on the pull request:
https://github.com/apache/spark/pull/7275#issuecomment-119730852
Looks good (with the minor style fix) -- much clearer than it was before!
I was a little concerned about what would happen when you submit a job
which re-uses a previously computed stage -- would the stage attempt ids inside
the job start be consistent before and after this change? But I ran a small
example and I realized it doesn't matter. If a shuffle output is reused, we
dont' actually reuse the stage, we make a new one which gets skipped. (I
thought there was some circumstance where two jobs could refer to the exact
same stage, but I can't seem to recreate it now ... is it possible?)
Its kinda weird that job start even has the attempts for the stage, since
they will always be 0, but I guess that is just an artifact of reusing the
`StageInfo` object.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
