Github user feynmanliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7099#discussion_r34200150
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
    @@ -209,7 +219,13 @@ class LinearRegression(override val uid: String)
     
         if (handlePersistence) instances.unpersist()
     
    -    copyValues(new LinearRegressionModel(uid, weights, intercept))
    +    val model = copyValues(new LinearRegressionModel(uid, weights, 
intercept))
    --- End diff --
    
    Actually, I need to call copyValues there because `model.transform` used on 
L223 requires `predictCol` to be set. 
`JavaLinearRegressionSuite#linearRegressionWithSetters()` will fail otherwise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to