Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7080#discussion_r34204113
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -232,16 +236,26 @@ class LogisticRegressionSuite extends SparkFunSuite
with MLlibTestSparkContext {
val interceptR = 2.8366423
val weightsR = Array(-0.5895848, 0.8931147, -0.3925051, -0.7996864)
- assert(model.intercept ~== interceptR relTol 1E-3)
- assert(model.weights(0) ~== weightsR(0) relTol 1E-3)
- assert(model.weights(1) ~== weightsR(1) relTol 1E-3)
- assert(model.weights(2) ~== weightsR(2) relTol 1E-3)
- assert(model.weights(3) ~== weightsR(3) relTol 1E-3)
+ assert(model1.intercept ~== interceptR relTol 1E-3)
+ assert(model1.weights(0) ~== weightsR(0) relTol 1E-3)
--- End diff --
BTW, this will be tricky with L1 since some of the coefficients can be
zero. We can workaround this with `absTol`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
