Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7241#discussion_r34209450
--- Diff: dev/lint-python ---
@@ -70,4 +70,26 @@ fi
# rm "$PEP8_SCRIPT_PATH"
rm "$PYTHON_LINT_REPORT_PATH"
+# Easy install pylint in /dev/pylint. To easy_install into a directory,
the PYTHONPATH should
+# be set to the directory.
+# dev/pylint should be appended to the PATH variable as well.
+export "PYTHONPATH=$SPARK_ROOT_DIR/dev/pylint"
+export "PYLINT_HOME=$PYTHONPATH"
+export "PATH=$PYTHONPATH:$PATH"
+
+if [ ! -d "$PYLINT_HOME" ]; then
+ mkdir "$PYLINT_HOME"
+ easy_install -d "$PYLINT_HOME" pylint
+ easy_install_status="$?"
+
+ if [ "$easy_install_status" -ne 0 ]; then
+ echo "Unable to install pylint locally in \"$PYTHONPATH\"."
+ fi
+fi
+
+for to_be_checked in "$PATHS_TO_CHECK"
+do
+ pylint --rcfile="$PYLINT_HOME/pylint.config" $to_be_checked
--- End diff --
Similar to what we do for pep8, can we redirect the output to a file and
only print it when an error occurs? (Maybe pylint has a quiet mode for this?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
