Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7283#discussion_r34210774
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -199,23 +199,23 @@ case class Cast(child: Expression, dataType:
DataType) extends UnaryExpression w
// TimestampWritable.floatToTimestamp
case FloatType =>
buildCast[Float](_, f => try {
- decimalToTimestamp(Decimal(f))
+ decimalToTimestamp(Decimal(f.toString))
--- End diff --
which test case is this? I think it is ok to lose precision if it is a
float.
cc @marmbrus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
