Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7303#discussion_r34216549
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/AbstractDataType.scala
---
@@ -34,9 +34,16 @@ private[sql] abstract class AbstractDataType {
private[sql] def defaultConcreteType: DataType
/**
- * Returns true if this data type is a parent of the `childCandidate`.
+ * Returns true if this data type is the same type as `other`. This is
different that equality
+ * as equality will also consider data type parametrization, such as
decimal precision.
--- End diff --
while you are at it, i think you can just give an example here, e.g.
DecimalType.isSameType(DecimalType(10, 2)) returns true, but
NumericType.isSameType(...) returns false
to make it more clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
