Github user davies commented on the pull request:
https://github.com/apache/spark/pull/7306#issuecomment-119806113
@JoshRosen Usually, we return an read-only GenericInternalRow by `copy()`,
which could be used by HashTable or others, no `update()` will be called. For
BroadcastHashJoin(), the copied Row will be lockuped by other InternalRow, it's
important to have same implementation of `hashCode` and `equal()`, but
UnsafeRow is different than other `InternalRow`, so I think it should not
return a UnsafeRow by `copy`, otherwise it's still can not be used with others.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
