Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7315#discussion_r34224477
  
    --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/Interval.java 
---
    @@ -44,4 +44,9 @@ public boolean equals(Object other) {
       public int hashCode() {
         return 31 * months + (int) microseconds;
       }
    +
    +  @Override
    +  public String toString() {
    +    return "interval: " + months + " months and " + microseconds + " 
microseconds";
    --- End diff --
    
    can we make this better?
    
    0. remove the : after interval
    1. if months = 0, don't show the month part
    2. ideally, show x days y seconds and such, instead of showing directly the 
number of ms


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to