Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r34226080
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -600,3 +604,146 @@ case class Logarithm(left: Expression, right:
Expression)
"""
}
}
+
+case class Round(child: Expression, scale: Expression) extends Expression
with ExpectsInputTypes {
+
+ def this(child: Expression) = {
+ this(child, Literal(0))
+ }
+
+ override def children: Seq[Expression] = Seq(child, scale)
+
+ override def nullable: Boolean = true
+
+ override def foldable: Boolean = child.foldable
+
+ override lazy val dataType: DataType = child.dataType match {
+ case DecimalType.Fixed(p, s) => DecimalType(p, _scale)
+ case t => t
+ }
+
+ override def inputTypes: Seq[AbstractDataType] = Seq(
+ // rely on precedence to implicit cast String into Double
+ TypeCollection(DecimalType, DoubleType, FloatType, LongType,
IntegerType, ShortType, ByteType),
+ TypeCollection(LongType, IntegerType, ShortType, ByteType))
+
+ override def checkInputDataTypes(): TypeCheckResult = {
+ child.dataType match {
+ case _: NumericType => // satisfy requirement
+ case dt =>
+ return TypeCheckFailure(s"Only numeric type is allowed for ROUND
function, got $dt")
+ }
+ scale match {
+ case Literal(value, LongType) =>
+ if (value.asInstanceOf[Long] < Int.MinValue ||
value.asInstanceOf[Long] > Int.MaxValue) {
+ return TypeCheckFailure("ROUND scale argument out of allowed
range")
+ }
+ case _ =>
+ if (scale.dataType.isInstanceOf[IntegralType] && scale.foldable) {
+ // TODO: How to check out of range for foldable LongType
Expression
+ // satisfy requirement
+ } else {
+ return TypeCheckFailure("Only foldable Integral Expression " +
+ s"is allowed for ROUND scale arguments, got ${child.dataType}")
+ }
+ }
+ TypeCheckSuccess
+ }
+
+ private lazy val scaleV = scale.eval(EmptyRow)
+ private lazy val _scale = if (scaleV != null) scaleV.asInstanceOf[Int]
else 0
+
+ override def eval(input: InternalRow): Any = {
+ val evalE = child.eval(input)
+ if (evalE == null || scaleV == null) return null
+ round(evalE)
+ }
+
+ private lazy val round: (Any) => (Any) = typedRound(child.dataType)
+
+ // Using dataType info to find an appropriate round method
+ private def typedRound(dt: DataType)(x: Any): Any = {
--- End diff --
this is too complicated i think.
just inline this in nullsafeeval - no need to create a function or use
currying here. performance for the non-codegen path doesn't matter that much.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
