Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/7316#discussion_r34228555
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala
---
@@ -117,6 +122,8 @@ abstract class ExtractValueWithStruct extends
UnaryExpression with ExtractValue
/**
* Returns the value of fields in the Struct `child`.
+ *
+ * No need to do type checking since it is handled by [[ExtractValue]].
--- End diff --
We already have doc for `trait ExtractValue` says "Note: concrete extract
value expressions are created only by `ExtractValue.apply`, we don't need to do
type check for them." Should we say it again here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
