Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7301#discussion_r34230085
  
    --- Diff: python/pyspark/sql/types.py ---
    @@ -71,6 +67,15 @@ def json(self):
                               separators=(',', ':'),
                               sort_keys=True)
     
    +    def needSerialization(self):
    --- End diff --
    
    This is expected to be override(also may be expensive), I think it's better 
to be a method, instead of property.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to