Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7266#discussion_r34298625
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
    @@ -65,12 +66,15 @@ class StringIndexer(override val uid: String) extends 
Estimator[StringIndexerMod
       def this() = this(Identifiable.randomUID("strIdx"))
     
       /** @group setParam */
    +  def setSkipInvalid(value: Boolean): this.type = set(skipInvalid, value)
    --- End diff --
    
    Looking at the other params in the StringIndexer model as well as 
LogisticRegression (e.g. setThreshold) it seems that when a param makes sense 
to be set on the model it is exposed in both the model and the trainer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to