Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7253#discussion_r34302678
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -413,8 +413,9 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
/**
* Comparison function that defines the sort order for application
attempts within the same
- * application. Order is: running attempts before complete attempts,
running attempts sorted
- * by start time, completed attempts sorted by end time.
+ * application. Order is: completed attempts before running attempts,
running attempts sorted
+ * by start time showing whichever started first,
--- End diff --
Wording is weird. What does "showing" mean?
I'd say: "sorted by descending start time", "sorted by descending end time".
Note, also, that your current code sorts in ascending order, while I think
it should be the opposite.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
