Github user koeninger commented on the pull request:
https://github.com/apache/spark/pull/7254#issuecomment-120150575
"zookeeper.connect" and "group.id" aren't necessary for anything in the
kafka direct stream.
But they're expected to be present in a kafka consumer config, and
overriding that behavior wasn't possible. So as a workaround, we set them to a
blank string. That way users don't have to define unnecessary settings in the
kafka param map passed to the KafkaUtils constructor. We talked through that
during the original development of the direct stream.
The code as it is released today is almost always going to set a blank
string, regardless of what users pass in, because contains on a java property
object is not the equivalent of containsKey, it is containsValue. This just
fixes it so that if they do pass in values for those keys, for whatever
personal reasons they have, the values won't get overwritten with a blank
string.
TL;DR this should have no impact, but is a good bugfix so that the code
does what it looks like it's supposed to.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
