Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7333#issuecomment-120173499
@BryanCutler We should keep the changes minimal for bug fixes. I thought
about the logic again. If we set numBlocks based on the input number of
partitions when numBlocks is -1, we basically assume that users know how to
control the number of RDD partitions, while is often not true. So a quick fix
would be `require(numBlocks > 0)` in the `branch-1.3` branch. Branch-1.4
already handles that. Sorry about going back and forth! Could you submit a new
PR to branch-1.3 and add this check? If you feel `or` is also useful for other
cases, we can create a new JIRA for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
