Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7307#discussion_r34323374
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/clustering/LDASuite.scala ---
@@ -131,8 +131,8 @@ class LDASuite extends SparkFunSuite with
MLlibTestSparkContext {
test("setter alias") {
val lda = new LDA().setAlpha(2.0).setBeta(3.0)
- assert(lda.getAlpha === 2.0)
- assert(lda.getDocConcentration === 2.0)
+ assert(lda.getAlpha.toArray.forall(_ === 2.0))
--- End diff --
Order of setting k and alpha no longer matters (see discussion L123).
Setter taking vector is tested in `test("OnlineLDAOptimizer with asymmetric
prior")`.
Will add test for sad path.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
