Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6851#discussion_r34323619
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -1073,11 +1073,30 @@ object functions {
       def floor(columnName: String): Column = floor(Column(columnName))
     
       /**
    -   * Computes hex value of the given column
    +   * Returns the greatest value of the list of values.
        *
    -   * @group math_funcs
    +   * @group normal_funcs
        * @since 1.5.0
        */
    +  @scala.annotation.varargs
    +  def greatest(exprs: Column*): Column = Greatest(exprs.map(_.expr): _*)
    +
    +  /**
    +   * Returns the greatest value of the list of column names.
    +   *
    +   * @group normal_funcs
    +   * @since 1.5.0
    +   */
    +  @scala.annotation.varargs
    +  def greatest(columnName: String, columnNames: String*): Column =
    +    greatest((columnName +: columnNames).map(Column.apply): _*)
    +
    +  /**
    +    * Computes hex value of the given column
    --- End diff --
    
    Nit:
    /**
     * Computes hex value for the given column.
     *



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to