Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6783#discussion_r34336689
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -387,3 +387,67 @@ case class MinOf(left: Expression, right: Expression)
extends BinaryArithmetic {
override def symbol: String = "min"
override def prettyName: String = symbol
}
+
+case class Pmod(left: Expression, right: Expression) extends
BinaryArithmetic {
+
+ override def symbol: String = "pmod"
+
+ protected def checkTypesInternal(t: DataType) =
+ TypeUtils.checkForNumericExpr(t, "pmod")
+
+ override lazy val resolved =
+ childrenResolved && checkInputDataTypes().isSuccess &&
!DecimalType.isFixed(dataType)
+
+ protected override def nullSafeEval(left: Any, right: Any) =
+ dataType match {
+ case IntegerType => pmod(left.asInstanceOf[Integer],
right.asInstanceOf[Integer])
+ case LongType => pmod(left.asInstanceOf[Long],
right.asInstanceOf[Long])
+ case ShortType => pmod(left.asInstanceOf[Short],
right.asInstanceOf[Short])
+ case ByteType => pmod(left.asInstanceOf[Byte],
right.asInstanceOf[Byte])
+ case FloatType => pmod(left.asInstanceOf[Float],
right.asInstanceOf[Float])
+ case DoubleType => pmod(left.asInstanceOf[Double],
right.asInstanceOf[Double])
+ case _: DecimalType => pmod(left.asInstanceOf[Decimal],
right.asInstanceOf[Decimal])
+ }
+
+ val decimalAddMethod = "$plus"
+
+ override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode):
String = dataType match {
+ case dt: DecimalType =>
+ defineCodeGen(ctx, ev, (eval1, eval2) =>
+
s"""($eval1.remainder($eval2).$decimalAddMethod($eval2)).remainder($eval2)""")
+ // byte and short are casted into int when add, minus, times or divide
+ case ByteType | ShortType =>
+ defineCodeGen(ctx, ev, (eval1, eval2) =>
+ s"(${ctx.javaType(dataType)})(($eval1 % $eval2 + $eval2) %
$eval2)")
+ case _ =>
+ defineCodeGen(ctx, ev, (eval1, eval2) => s"($eval1 % $eval2 +
$eval2) % $eval2")
+ }
+
+ private def pmod(a: Integer, n: Integer): Integer = {
+ (a % n + n) % n
+ }
+
+ private def pmod(a: Long, n: Long): Long = {
+ (a % n + n) % n
--- End diff --
pmod(1, Long.MaxValue) will return -1 in this case, and hive does the same
thing. Is that OK?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
