Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6394#discussion_r34384724
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala ---
    @@ -24,11 +24,15 @@ package org.apache.spark
     private[spark] trait ExecutorAllocationClient {
     
       /**
    -   * Express a preference to the cluster manager for a given total number 
of executors.
    +   * Express a preference to the cluster manager for a given total number 
of executors,
    +   * number of locality aware pending tasks and related locality 
preferences.
        * This can result in canceling pending requests or filing additional 
requests.
        * @return whether the request is acknowledged by the cluster manager.
        */
    -  private[spark] def requestTotalExecutors(numExecutors: Int): Boolean
    +  private[spark] def requestTotalExecutors(
    +      numExecutors: Int,
    +      localityAwarePendingTasks: Int,
    +      preferredLocalityToCount: Map[String, Int]): Boolean
    --- End diff --
    
    what about calling this executorToLocalTaskCount?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to