Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6981#discussion_r34404484
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -54,3 +60,341 @@ case class CurrentTimestamp() extends LeafExpression {
System.currentTimeMillis() * 1000L
}
}
+
+/**
+ * Abstract class for create time format expressions.
+ */
+abstract class TimeFormatExpression extends UnaryExpression with
ExpectsInputTypes {
--- End diff --
I find this intermediate abstract class a bit excessive. I'm not sure how
much benefits it provides. Can you just get rid of it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
