Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7360#discussion_r34484732
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/fpm/LocalPrefixSpan.scala ---
@@ -42,22 +44,20 @@ private[fpm] object LocalPrefixSpan extends Logging
with Serializable {
def run(
minCount: Long,
maxPatternLength: Int,
- prefix: Array[Int],
- projectedDatabase: Array[Array[Int]]): Array[(Array[Int], Long)] = {
+ prefix: ArrayBuffer[Int],
--- End diff --
`ArrayBuilder` is better than `ArrayBuffer` for `Int`. The latter is not
specialized for `Int` and hence has boxing/unboxing overhead. But here, we may
want to consider `List` to avoid re-allocating buffers. The cost is that we
have to inverse the list, e.g.,
https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/mllib/fpm/FPTree.scala#L72.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
