Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/837#discussion_r13262640
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/joins.scala ---
    @@ -144,6 +144,150 @@ case class HashJoin(
      * :: DeveloperApi ::
    --- End diff --
    
    I realize that we aren't particularly good about this in most of the other 
physical operators, but could you add some Scala doc here about how this 
operator works and what the expected performance characteristics are?  Same 
below.  The goal of the Scala doc for physical operators should be to make it 
easy for people to understand query plans that are printed out by EXPLAIN.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to