Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/897#discussion_r13263116
--- Diff: core/src/main/scala/org/apache/spark/api/java/JavaPairRDD.scala
---
@@ -672,38 +672,102 @@ class JavaPairRDD[K, V](val rdd: RDD[(K, V)])
/**
* Return approximate number of distinct values for each key in this RDD.
+ *
* The accuracy of approximation can be controlled through the relative
standard deviation
* (relativeSD) parameter, which also controls the amount of memory
used. Lower values result in
* more accurate counts but increase the memory footprint and vise
versa. Uses the provided
* Partitioner to partition the output RDD.
+ *
+ * @param p The precision value for the normal set.
+ * <code>p</code> must be a value between 4 and <code>sp</code>
(32 max).
+ * @param sp The precision value for the sparse set, between 0 and 32.
+ * If <code>sp</code> equals 0, the sparse representation is
skipped.
+ * @param partitioner Partitioner to use for the resulting RDD.
*/
- def countApproxDistinctByKey(relativeSD: Double, partitioner:
Partitioner): JavaRDD[(K, Long)] = {
- rdd.countApproxDistinctByKey(relativeSD, partitioner)
+ def countApproxDistinctByKey(p: Int, sp: Int, partitioner: Partitioner):
JavaPairRDD[K, Long] = {
+ fromRDD(rdd.countApproxDistinctByKey(p, sp, partitioner))
}
/**
- * Return approximate number of distinct values for each key this RDD.
+ * Return approximate number of distinct values for each key in this RDD.
+ *
* The accuracy of approximation can be controlled through the relative
standard deviation
* (relativeSD) parameter, which also controls the amount of memory
used. Lower values result in
- * more accurate counts but increase the memory footprint and vise
versa. The default value of
- * relativeSD is 0.05. Hash-partitions the output RDD using the existing
partitioner/parallelism
- * level.
+ * more accurate counts but increase the memory footprint and vise
versa. Uses the provided
+ * Partitioner to partition the output RDD.
+ *
+ * @param p The precision value for the normal set.
+ * <code>p</code> must be a value between 4 and <code>sp</code>
(32 max).
+ * @param sp The precision value for the sparse set, between 0 and 32.
+ * If <code>sp</code> equals 0, the sparse representation is
skipped.
+ * @param numPartitions The number of partitions in the resulting RDD.
*/
- def countApproxDistinctByKey(relativeSD: Double = 0.05): JavaRDD[(K,
Long)] = {
- rdd.countApproxDistinctByKey(relativeSD)
+ def countApproxDistinctByKey(p: Int, sp: Int, numPartitions: Int):
JavaPairRDD[K, Long] = {
+ fromRDD(rdd.countApproxDistinctByKey(p, sp, numPartitions))
}
-
/**
* Return approximate number of distinct values for each key in this RDD.
+ *
+ * The accuracy of approximation can be controlled through the relative
standard deviation
+ * (relativeSD) parameter, which also controls the amount of memory
used. Lower values result in
+ * more accurate counts but increase the memory footprint and vise
versa. Uses the provided
+ * Partitioner to partition the output RDD.
+ *
+ * @param p The precision value for the normal set.
+ * <code>p</code> must be a value between 4 and <code>sp</code>
(32 max).
+ * @param sp The precision value for the sparse set, between 0 and 32.
+ * If <code>sp</code> equals 0, the sparse representation is
skipped.
+ */
+ def countApproxDistinctByKey(p: Int, sp: Int): JavaPairRDD[K, Long] = {
+ fromRDD(rdd.countApproxDistinctByKey(p, sp))
+ }
+
+ /**
+ * Return approximate number of distinct values for each key in this
RDD. This is deprecated.
+ * Use the variant with <code>p</code> and <code>sp</code> parameters
instead.
+ *
* The accuracy of approximation can be controlled through the relative
standard deviation
* (relativeSD) parameter, which also controls the amount of memory
used. Lower values result in
- * more accurate counts but increase the memory footprint and vise
versa. HashPartitions the
- * output RDD into numPartitions.
+ * more accurate counts but increase the memory footprint and vise
versa. Uses the provided
+ * Partitioner to partition the output RDD.
+ */
+ @Deprecated
+ def countApproxDistinctByKey(relativeSD: Double, partitioner:
Partitioner): JavaPairRDD[K, Long] =
+ {
+ fromRDD(rdd.countApproxDistinctByKey(relativeSD, partitioner))
+ }
+
+ /**
+ * Return approximate number of distinct values for each key in this
RDD. This is deprecated.
+ * Use the variant with <code>p</code> and <code>sp</code> parameters
instead.
+ *
+ * The algorithm used is based on streamlib's implementation of
"HyperLogLog in Practice:
+ * Algorithmic Engineering of a State of The Art Cardinality Estimation
Algorithm", available at
+ * [[http://research.google.com/pubs/pub40671.html]].
+ *
+ * @param relativeSD The relative standard deviation for the counter.
+ * Smaller values create counters that require more
space.
+ */
+ @Deprecated
+ def countApproxDistinctByKey(relativeSD: Double, numPartitions: Int):
JavaPairRDD[K, Long] = {
+ fromRDD(rdd.countApproxDistinctByKey(relativeSD, numPartitions))
+ }
+
+ /**
+ * Return approximate number of distinct values for each key in this
RDD. This is deprecated.
+ * Use the variant with <code>p</code> and <code>sp</code> parameters
instead.
+ *
+ * The algorithm used is based on streamlib's implementation of
"HyperLogLog in Practice:
+ * Algorithmic Engineering of a State of The Art Cardinality Estimation
Algorithm", available at
+ * [[http://research.google.com/pubs/pub40671.html]].
*
+ * @param relativeSD The relative standard deviation for the counter.
+ * Smaller values create counters that require more
space.
*/
- def countApproxDistinctByKey(relativeSD: Double, numPartitions: Int):
JavaRDD[(K, Long)] = {
- rdd.countApproxDistinctByKey(relativeSD, numPartitions)
+ @Deprecated
+ def countApproxDistinctByKey(relativeSD: Double): JavaPairRDD[K, Long] =
{
--- End diff --
Note that I changed the return type from JavaRDD[(K, Long)] to
JavaPairRDD[K, Long], because that is what it should've been.
However, in order to maintain complete API stability, I can change it back
and just deprecated the old methods. The new methods certainly should return
JavaPairRDD.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
