Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7378#issuecomment-121079986
Hi @njhwang,
Thanks for submitting this pull request. Do you mind filing a JIRA ticket
at https://issues.apache.org/jira/browse/SPARK to report this issue?
Check out
https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark for an
overview of how the Spark contribution process works.
I agree that we should try to guard against mutation of the zero original
zero value. I'd also look into whether we should be using a copy on line 904
in `return self.mapPartitions(func).fold(zeroValue, combOp)`; there might be
other cases that need to be addressed, too.
It would be good to add a regression test for this. Take a look at
`python/pyspark/tests.py` for examples of how to do this (once you've created
the JIRA, I'd reference the JIRA ticket number in your test via a line comment).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
