Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7365#discussion_r34521956
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -421,48 +421,364 @@ case class Cast(child: Expression, dataType:
DataType) extends UnaryExpression w
protected override def nullSafeEval(input: Any): Any = cast(input)
- override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode):
String = {
- // TODO: Add support for more data types.
- (child.dataType, dataType) match {
+ override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode):
String =
+ castGen(child.dataType, dataType, ctx, ev)
- case (BinaryType, StringType) =>
- defineCodeGen (ctx, ev, c =>
- s"${ctx.stringType}.fromBytes($c)")
+ private[this] def castGen(from: DataType, to: DataType, ctx:
CodeGenContext,
--- End diff --
why not remove this and put it into genCode directly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
