Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/7276#discussion_r34527987
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala
---
@@ -227,6 +255,8 @@ class ReceiverTracker(ssc: StreamingContext,
skipReceiverLaunch: Boolean = false
case DeregisterReceiver(streamId, message, error) =>
deregisterReceiver(streamId, message, error)
context.reply(true)
+ case ScheduleReceiver(streamId) =>
--- End diff --
I think this messaging should be done differently to align the messaging
style with the other messages. It does not make sense for the receiver to fetch
all the allowed locations that the receiver is allowed to start. Rather it
should be
`ShouldStartReceiver`, which returns true or false, and accordingly the
receiver is started by the `ReceiverSupervisor`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
