Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/7280#discussion_r34587406
--- Diff: core/src/main/scala/org/apache/spark/api/r/SerDe.scala ---
@@ -46,9 +46,18 @@ private[spark] object SerDe {
dis.readByte().toChar
}
- def readObject(dis: DataInputStream): Object = {
+ def readObject(dis: DataInputStream, typeName: String = ""): Object = {
--- End diff --
Hmm - do we need it though ? In `bytesToRow` you can just do the conversion
if the typename is float ? Something like
```
val obj = SerDe.readObject(dis)
if (schemaTypeName == "Float") obj.asInstanceOf[Double].floatValue() else
obj
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
