Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/7392#discussion_r34591393
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -56,6 +56,16 @@ class CodeGenContext {
*/
val references: mutable.ArrayBuffer[Expression] = new
mutable.ArrayBuffer[Expression]()
+ val mutableStates: mutable.ArrayBuffer[String] =
mutable.ArrayBuffer.empty[String]
--- End diff --
ISTM that all the kinds of generated stuffs should be put in
GeneratedExpressionCode, not in CodeGenContext
according to the source code comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
