Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/7379#issuecomment-121316725
This looks pretty cool! I can try and do a more through review in a bit,
but a few testing suggestions:
It would be great to add a test for the query planner
[PlannerSuite](https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala)
I would also add some unit tests for the operator itself, probably a new
class modeled after
[OuterJoinSuite](https://github.com/apache/spark/blob/0c5207c66db8cf76950d53404abd43e085f8d45b/sql/core/src/test/scala/org/apache/spark/sql/execution/joins/OuterJoinSuite.scala)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
