Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/7352#issuecomment-121319255
I think the bug / PR title are just confusingly worded, but the fix is
correct. It's because of this note in the
`ScheduledExecutorService::scheduleAtFixedRate` documentation:
If any execution of the task encounters an exception, subsequent
executions are suppressed.
So exceptions need to be ignored while the allocation manager is running.
`logUncaughtExceptions` just logs them, but lets the exceptions bubble up (and
thus stop the task).
Only thing is that I never know which exception to catch in Scala (is it
`ControlThrowable` or `NonFatal(e)`?).
I'd use a clearer title for the PR, something like: "Catch exceptions in
allocation schedule task." You could explain why that needs to be done in the
description, instead of trying to use the title for that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
