Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7401#discussion_r34608846
--- Diff: dev/sparktestsupport/__init__.py ---
@@ -19,3 +19,14 @@
SPARK_HOME =
os.path.abspath(os.path.join(os.path.dirname(os.path.realpath(__file__)),
"../../"))
USER_HOME = os.environ.get("HOME")
+ERROR_CODES = { "BLOCK_GENERAL" : 10,
--- End diff --
Style nit: the problem with putting the first element of the dict on the
same line as the opening `{` is that the indentation of all of the other
elements is dependent on the variable name. If we were to rename `ERROR_CODES`
to something else then all of the indentation would have to change. Instead,
I'd move `BLOCK_GENERAL` to the next line and just indent the elements four
spaces.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
