Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/7159#discussion_r34623467
--- Diff: core/src/main/scala/org/apache/spark/rpc/akka/AkkaRpcEnv.scala ---
@@ -237,6 +237,12 @@ private[spark] class AkkaRpcEnv private[akka] (
}
override def toString: String =
s"${getClass.getSimpleName}($actorSystem)"
+
+ def deserialize[T](deserializationAction: () => T): T = {
+
JavaSerializer.currentSystem.withValue(actorSystem.asInstanceOf[ExtendedActorSystem])
{
--- End diff --
I see, because now we no longer pass akka's `Serialization`, which has
information about the actor system, into `PersistenceEngine`, so here we ensure
that we're using the actor system's serializer.
But more generally, since we always serialize with `JavaSerializer` in the
new code, why can't we always deserialize with the same thing? I just find it a
little strange that we have to pass a closure into this method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
