Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7128#discussion_r34625945
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala ---
    @@ -47,4 +47,10 @@ private[spark] trait ExecutorAllocationClient {
        * @return whether the request is acknowledged by the cluster manager.
        */
       def killExecutor(executorId: String): Boolean = 
killExecutors(Seq(executorId))
    +
    +  /**
    +   * Request that the cluster manager kill the specified executor and 
expect new one
    +   * @return whether the request is acknowledged by the cluster manager.
    +   */
    +  def expireExecutor(executorId: String): Boolean
    --- End diff --
    
    This is a confusing name. Without reading the java docs I have no idea what 
the difference between `killExecutor` and `expireExecutor` is


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to