Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/7385#discussion_r34634183
--- Diff: core/src/main/scala/org/apache/spark/scheduler/JobWaiter.scala ---
@@ -28,12 +31,18 @@ private[spark] class JobWaiter[T](
resultHandler: (Int, T) => Unit)
extends JobListener {
+ private val promise = Promise[Unit]
--- End diff --
Stepping back. If we are using promise any ways, why do we need a separate
variable called "jobFinished"? The promise is sufficient in keeping the state
of whether the job has finished or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
