Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/936#discussion_r13270287
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
 ---
    @@ -115,3 +131,21 @@ case class RLike(left: Expression, right: Expression)
       override def escape(v: String): String = v
       override def matches(regex: Pattern, str: String): Boolean = 
regex.matcher(str).find(0)
     }
    +
    +/**
    + * System function upper()
    + * */
    +case class Upper(child: Expression)
    +  extends UnaryExpression with CaseConversionExpression {
    +  
    +  override def convert(v: String): String = {v.toUpperCase()}
    --- End diff --
    
    Please either remove the braces or start the function body in a new line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to