Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7381#issuecomment-121485499
@ericl I make another pass. The major issue is actually that
`RModelFormula` should be an `Estimator` instead of a `Transformer` in order to
handle String columns. It requires some changes to the current implementation.
So I would suggest removing the support for string labels in this PR and
address it in a follow-up PR, since we already reviewed most of the code. It is
okay to just comment out the test. Does it sound good to you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
