Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/933#discussion_r13271716
  
    --- Diff: 
graphx/src/main/scala/org/apache/spark/graphx/lib/ShortestPaths.scala ---
    @@ -0,0 +1,72 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.graphx.lib
    +
    +import org.apache.spark.graphx._
    +import scala.reflect.ClassTag
    +
    +/**
    + * Computes shortest paths to the given set of landmark vertices, 
returning a graph where each
    + * vertex attribute is a map containing the shortest-path distance to each 
reachable landmark.
    + */
    +object ShortestPaths {
    +  /** Stores a map from the vertex id of a landmark to the distance to 
that landmark. */
    +  type SPMap = Map[VertexId, Int]
    +
    +  def SPMap(x: (VertexId, Int)*) = Map(x: _*)
    --- End diff --
    
    Can we remove this one? It technically violates our coding style to have a 
function start with upper case, and confusing to have it the same name as the 
type itself.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to