Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7390#discussion_r34665003
--- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/Interval.java
---
@@ -43,12 +43,13 @@
* Finally is the unit name, ends with an optional "s".
*/
private static String unitRegex(String unit) {
- return "(?:\\s+(-?\\d+)\\s+" + unit + "s?)?";
+ return "(?:\\s+(-?\\d+)\\s+" + unit + "s?\\s*)?";
--- End diff --
@rxin I'm not worried about the package so much as the module; this doesn't
have to do with bit-twiddling via Unsafe. Is there really a win for managing 96
bits via Unsafe?
It doesn't seem like the right place for this type; it's only used by
catalyst (now) I think, so could live there or at least core. But more than
that, the JDK itself has a standard class for this -- around which you could
build utility functions. I understand this is in flux but I suppose I'm not
seeing why it landed here and wondering if it's better to move it early.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
