Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/6617#discussion_r34751311
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTableSupport.scala
---
@@ -105,8 +104,7 @@ private[parquet] class RowReadSupport extends
ReadSupport[InternalRow] with Logg
// If the parquet file is thrift derived, there is a good chance that
// it will have the thrift class in metadata.
val isThriftDerived =
keyValueMetaData.keySet().contains("thrift.class")
- parquetSchema = ParquetTypesConverter
- .convertFromAttributes(requestedAttributes, isThriftDerived)
+ parquetSchema =
ParquetTypesConverter.convertFromAttributes(requestedAttributes)
--- End diff --
It's not needed anymore, since the converter already handles parquet-thrift
files in a consistent way via backwards-compatibility rules. It's also proven
by `ParquetThriftCompatibilitySuite`.
(Hm, forgot to remove Thrift related code here.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
