Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7294#issuecomment-121842954
@jkbradley I made one pass:
1. Some of my comments also apply to the old implementation. So I don't
think it is necessary to address them in this PR.
2. It is quite hard to track what have been changed, because you merged
DecisionTree and RandomForest into one file and removed bins. Next time we
should think of a better approach, making the real changes more discoverable.
Except some style issues and the random seed, it looks good to me:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
